Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Assign result of InstanceType creation on initialisation when dynamic #3110

Closed
wants to merge 1 commit into from
Closed

[WIP] Assign result of InstanceType creation on initialisation when dynamic #3110

wants to merge 1 commit into from

Conversation

gjtempleton
Copy link
Member

@gjtempleton gjtempleton commented May 4, 2020 •
edited
Loading

This isn't currently the best approach I think. It's highlighted the that the instanceTypes of the awsCloudProvider doesn't actually appear to be used anywhere currently.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jeffwan
You can assign the PR to them by writing /assign @jeffwan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from feiskyer and Jeffwan May 4, 2020 12:17
@RobertLucian RobertLucian mentioned this pull request May 8, 2020
Closed
@RobertLucian
Copy link

LGTM. I tested it here #3095 (comment).

@deliahu deliahu mentioned this pull request May 22, 2020
Closed
@RobertLucian RobertLucian mentioned this pull request Jun 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@Jeffwan Jeffwan Awaiting requested review from Jeffwan

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] - CA AWS Dynamic InstanceTypes Generation Ignored
3 participants
@gjtempleton @k8s-ci-robot @RobertLucian